[#1013] Implement the Database Adapter 3#1035
Open
marcocapozzoli wants to merge 5 commits intomasc/1013-database-adapter-cpp-2from
Open
[#1013] Implement the Database Adapter 3#1035marcocapozzoli wants to merge 5 commits intomasc/1013-database-adapter-cpp-2from
marcocapozzoli wants to merge 5 commits intomasc/1013-database-adapter-cpp-2from
Conversation
marcocapozzoli
changed the title
andre-senna
requested changes
Feb 11, 2026
Contributor
There was a problem hiding this comment.
The code inside DBWrapper.{h,cc} is a mess. Although you can define multiple classes in the same files in C++ (and although this is a good choice sometimes) most of the time you should keep one pair of .h and .cc files per class. I suggest you to do it this way here, splitting the classes you create din this file because I believe you are over-templatizing the code.
So please break down this code in multiple files before submitting it to review.
src/db_adapter/DBWrapper.h
Outdated
| @@ -3,42 +3,59 @@ | |||
| #include <memory> | |||
Contributor
There was a problem hiding this comment.
Please name the file with the name of the main class defined in it: DatabaseWrapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Processors to the database connection. i.e, implement commons/processor/Processor.h
Resolves #1013